fix: Validate arrow_cast time units#22206
Open
Dandandan wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
sqllogictest
Dandandan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
arrow_castandarrow_try_castaccepted Arrow time type strings that combineTime32/Time64with unsupported units. Those invalid types could reach later planning or execution paths and panic in Arrow array code.What changes are included in this PR?
arrow_cast/arrow_try_casttarget types before returning fields or simplifying casts.Time32(Microsecond),Time32(Nanosecond),Time64(Second), andTime64(Millisecond).Are these changes tested?
cargo test -p datafusion-sqllogictest --test sqllogictests -- arrow_typeofcargo clippy -p datafusion-functions --all-targets --all-features -- -D warningscargo fmt --allcargo clippy --all-targets --all-features -- -D warningsAre there any user-facing changes?
Invalid Arrow time type combinations now return a planning error instead of being accepted by
arrow_cast/arrow_try_cast.